`devshard`: It would be worth adding small tests asserting `pool.Config().MaxConns` for both payload storage constructors. `ConfigureMaxConns` itself is well tested, but the current tests wouldn’t catch the helper being accidentally removed from either constructor. #1851
Looks good overall, approved. It would be worth adding small tests asserting pool.Config().MaxConns for both payload storage constructors. ConfigureMaxConns itself is well tested, but the current tests wouldn’t catch the helper being accidentally removed from either constructor.
Originally posted by @aikuznetsov in https://github.com/gonka-ai/gonka/pull/1840#pullrequestreview-5312588423
🔄 Auto-synced from Issue #1851 every hour.